add configurable order function for Alphabetical Use Statement Sniff, fixes #5 #44
Conversation
README.md
Outdated
| * in arrays, the key and `=>` operator must be on the same line | ||
| * each consecutive variable assignment must align at the assignment operator | ||
| * use statements must be sorted lexicographically | ||
| * use statements must be sorted lexicographically, the order function can be configured |
xalopp
force-pushed
the
use_statement_dictionary_order
branch
from
4465223 to
ca937b5
Compare
|
@Ma27 👓 ! 😸 |
| } else if ('string-case-insensitive' === $this->order) { | ||
| return strcasecmp($a, $b); | ||
| } else { | ||
| return $this->dictionaryCompare($a, $b); |
There was a problem hiding this comment.
This method falls back to dictionary as validation approach by default. I've seen that PHPCS loves to mutate public properties using an XML, however I wonder if some kind of validation (e.g. throw an exception in here if order has an invalid value) makes sense to avoid unexpected behavior
There was a problem hiding this comment.
Added the check to register()
xalopp
force-pushed
the
use_statement_dictionary_order
branch
from
ca937b5 to
0e7bc21
Compare
| * | ||
| * @return int | ||
| */ | ||
| private function dictionaryCompare($a, $b) |
There was a problem hiding this comment.
@aoldemeier could you check the correctness of this function?
There was a problem hiding this comment.
After having realized I was confused about the signature of substr I am now convinced that the function is correct (making common sense assumptions about how dictionaryCompare should work)...
|
@xalopp please rebase :) |
xalopp
force-pushed
the
use_statement_dictionary_order
branch
from
920f2f9 to
daafdf0
Compare
| class AlphabeticalUseStatementsSniff extends UseDeclarationSniff | ||
| { | ||
|
|
||
| const NAMESPACE_SEPRATOR_STRING = '\\'; |
| * | ||
| * @return int | ||
| */ | ||
| private function dictionaryCompare($a, $b) |
There was a problem hiding this comment.
After having realized I was confused about the signature of substr I am now convinced that the function is correct (making common sense assumptions about how dictionaryCompare should work)...
No description provided.